fix: use sparkImage.pullPolicy in all containers - #764
Merged
Merged
Conversation
sweb
force-pushed
the
fix/use-pull-policy
branch
3 times, most recently
from
September 3, 2026 13:04
a7f8906 to
fd3967e
Compare
sweb
marked this pull request as ready for review
September 3, 2026 13:08
adwk67
self-requested a review
September 8, 2026 10:10
adwk67
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
sweb
force-pushed
the
fix/use-pull-policy
branch
from
September 8, 2026 10:38
e7a1601 to
fb03739
Compare
adwk67
reviewed
Sep 8, 2026
sweb
commented
Sep 10, 2026
sweb
left a comment
sweb
left a comment
Member
Author
There was a problem hiding this comment.
thank you for your review. I was able to improve it quite a bit - and remove a bug I didn't really understand / anticipate.
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
sweb
force-pushed
the
fix/use-pull-policy
branch
from
September 10, 2026 11:31
c9ae743 to
769d55f
Compare
adwk67
approved these changes
Sep 10, 2026
adwk67
left a comment
adwk67
left a comment
Member
There was a problem hiding this comment.
LGTM. I added a fix to test (previously broken by me) and ran all nightlies just to be sure:
--- PASS: kuttl (2592.62s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/spark-pi-private-s3_openshift-false_spark-4.1.2 (354.14s)
--- PASS: kuttl/harness/spark-connect-kerberos_openshift-false_iceberg-latest-1.11.0_hive-iceberg-4.0.0_spark-connect-4.1.2_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_s3-use-tls-true (823.55s)
--- PASS: kuttl/harness/custom-log-directory_openshift-false_spark-4.1.2_hdfs-latest-3.5.0_zookeeper-latest-3.9.5 (594.24s)
--- PASS: kuttl/harness/spark-examples_openshift-false_spark-4.1.2 (51.72s)
--- PASS: kuttl/harness/overrides_openshift-false_spark-4.1.2 (172.69s)
--- PASS: kuttl/harness/logging_openshift-false_spark-logging-4.1.2_ny-tlc-report-0.3.0 (389.54s)
--- PASS: kuttl/harness/resources_openshift-false_spark-4.1.2 (68.20s)
--- PASS: kuttl/harness/spark-history-server_openshift-false_spark-4.1.2_s3-use-tls-true (270.77s)
--- PASS: kuttl/harness/spark-connect_openshift-false_iceberg-latest-1.11.0_hive-iceberg-4.0.0_spark-connect-4.1.2_s3-use-tls-true (321.95s)
--- PASS: kuttl/harness/transit-encryption_openshift-false_spark-4.1.2 (64.87s)
--- PASS: kuttl/harness/signal-propagation_openshift-false_spark-4.1.2 (61.78s)
--- PASS: kuttl/harness/delta-lake_openshift-false_spark-delta-lake-4.1.2 (437.66s)
--- PASS: kuttl/harness/pyspark-ny-public-s3_openshift-false_spark-4.1.2 (136.85s)
--- PASS: kuttl/harness/product-config-compat_openshift-false_spark-regression-3.5.8 (36.15s)
--- PASS: kuttl/harness/hbase-connector_openshift-false_spark-hbase-connector-3.5.8_hbase-2.6.6_hdfs-latest-3.5.0_zookeeper-latest-3.9.5 (697.86s)
--- PASS: kuttl/harness/graceful-shutdown_openshift-false_spark-4.1.2 (116.04s)
--- PASS: kuttl/harness/config-overrides_openshift-false_spark-4.1.2 (75.18s)
--- PASS: kuttl/harness/iceberg_openshift-false_spark-iceberg-4.1.2_iceberg-latest-1.11.0 (88.64s)
--- PASS: kuttl/harness/smoke_openshift-false_spark-4.1.2_s3-use-tls-true (182.19s)
--- PASS: kuttl/harness/pyspark-ny-public-s3-image_openshift-false_spark-4.1.2_ny-tlc-report-0.3.0 (134.11s)
PASS
sweb
enabled auto-merge
September 10, 2026 14:32
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
lfrancke
moved this from Development: Done
to Acceptance: In Progress
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves #762
sparkImage.pullPolicyis no longer ignored by the driver and executor containers, the Spark Connect executors and the truststore andjobinit containers, and it now covers the user-suppliedspec.imagetoo.This has a breaking component, because this now leads to the default pull policy of
Alwaysfor driver and executor.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker